ngclinflows commented on code in PR #909: URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560782736
########## charts/apisix/README.md: ########## @@ -128,6 +128,7 @@ The command removes all the Kubernetes components associated with the chart and | apisix.status.ip | string | `"0.0.0.0"` | | | apisix.status.port | int | `7085` | | | apisix.stream_plugins | list | `[]` | Customize the list of APISIX stream_plugins to enable. By default, APISIX's [default stream_plugins](https://github.com/apache/apisix/blob/master/apisix/cli/config.lua#L294) are automatically used. | +| apisix.trustedAddresses[0] | string | `"127.0.0.1"` | | Review Comment: According to https://github.com/norwoodj/helm-docs, I think it was auto-generated. Adding a comment as I suggested will resolve this. Documentation quote: > The following rules are used to determine which values will be added to the values table in the README: > * By default, only leaf nodes, that is, fields of type int, string, float, bool, empty lists, and empty maps are added as rows in the values table. These fields will be added even if they do not have a description comment > * Lists and maps which contain elements will not be added as rows in the values table **unless they have a description comment which refers to them** > * Adding a description comment for a non-empty list or map in this way makes it so that leaf nodes underneath the described field will not be automatically added to the values table. In order to document both a non-empty list/map and a leaf node within that field, description comments must be added for both -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
