twellck commented on PR #12859: URL: https://github.com/apache/apisix/pull/12859#issuecomment-3717279679
Hi @Baoyuantop, Thank you for the response! While the proposed approach would indeed address the immediate issue, I believe it treats the symptom rather than the root cause. My current implementation attempts to address the underlying problem by introducing some standardisation to how listeners are managed going forward. Adding IPv6 listening directly to the template would further fragment how listeners (`node_listen`, `proxy_protocol.listen_http_port`, `control/admin/prometheus`, etc.) are managed in the APISIX and Nginx configuration. Each of these currently relies on slightly different approaches for defining listener behavior. This fragmentation not only increases maintenance complexity but also limits the ability to provide feature parity across all listening definitions. --- My proposed solution is fully backward-compatible, based on regression testing, and builds on the established patterns for `node_listen` and `ssl.listen` in APISIX (reworked into reusable functions). By leveraging these existing structures, my hope is to reduce ongoing maintenance efforts while making future listener functionality easier to extend. I understand that this PR addresses more than the specific issue, but I believe it’s worth considering how we could make Nginx configuration more standardised and maintainable for both developers and deployers of APISIX over time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
