membphis commented on code in PR #12864:
URL: https://github.com/apache/apisix/pull/12864#discussion_r2667138926
##########
apisix/plugins/basic-auth.lua:
##########
@@ -32,6 +32,10 @@ local schema = {
hide_credentials = {
type = "boolean",
default = false,
+ },
+ realm = {
+ type = "string",
Review Comment:
it can not contain any `'`, `"`
maybe we should limit it
##########
apisix/plugins/ldap-auth.lua:
##########
@@ -28,7 +28,8 @@ local schema = {
ldap_uri = { type = "string" },
use_tls = { type = "boolean", default = false },
tls_verify = { type = "boolean", default = false },
- uid = { type = "string", default = "cn" }
+ uid = { type = "string", default = "cn" },
+ realm = { type = "string", default = "ldap" }
Review Comment:
we can add a `,` at the end of this line always
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
