sihyeonn opened a new pull request, #12895:
URL: https://github.com/apache/apisix/pull/12895
Separate options and defaults behavior:
- options: always override user request values
- defaults: apply only when not set in user request
This allows more flexible configuration where administrators can enforce
certain values (via options) while providing sensible defaults for optional
parameters.
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Add defaults field to ai-proxy and ai-proxy-multi plugins to provide
fallback values for model options. Currently, options field always overrides
user request values. This PR introduces a new defaults field that only applies
when the user hasn't set a value in their request. Behavior:
- options: Always override user values (e.g., enforce specific model)
- defaults: Apply only when not present in user request (e.g., default
max_tokens)
Example configuration:
{
"options": { "model": "gpt-4" },
"defaults": { "max_tokens": 512, "temperature": 0.7 }
}
| User Request | Result
| -- | --
| {"model": "gpt-3.5"} | {"model": "gpt-4", "max_tokens": 512,
"temperature": 0.7}
| {"max_tokens": 100} | {"model": "gpt-4", "max_tokens": 100, "temperature":
0.7}
#### Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not,
please discuss on the [APISIX mailing
list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
