shreemaan-abhishek commented on code in PR #12856:
URL: https://github.com/apache/apisix/pull/12856#discussion_r2726314010
##########
apisix/utils/upstream.lua:
##########
@@ -117,11 +118,15 @@ function _M.parse_domain_in_up(up)
return up
end
- if not up.orig_modifiedIndex then
- up.orig_modifiedIndex = up.modifiedIndex
+ local nodes_ver = resource.get_nodes_ver(up.value.resource_key)
+ if not nodes_ver then
+ nodes_ver = 0
end
- up.modifiedIndex = up.orig_modifiedIndex .. "#" .. ngx_now()
+ nodes_ver = nodes_ver + 1
Review Comment:
After dns resolution, the nodes have changed, that's why we need to
increment the version. This is in fact the crux of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
