ChuanFF commented on code in PR #12852:
URL: https://github.com/apache/apisix/pull/12852#discussion_r2732529490
##########
apisix/discovery/kubernetes/init.lua:
##########
@@ -436,7 +440,8 @@ local function start_fetch(handle)
ngx.timer.at(0, timer_runner)
end
-local function get_endpoint_dict(id)
+
+local function get_endpoint_dict_name(id)
Review Comment:
The id is defined as a string in the
schemaļ¼https://github.com/apache/apisix/blame/master/apisix/discovery/kubernetes/schema.lua#L177
I added a type check to return a default value if the value is not a string.
Is this appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
