kayx23 commented on code in PR #12977:
URL: https://github.com/apache/apisix/pull/12977#discussion_r2769803144


##########
docs/en/latest/plugins/limit-count.md:
##########
@@ -44,8 +44,9 @@ You may see the following rate limiting headers in the 
response:
 
 | Name                    | Type    | Required                                 
 | Default       | Valid values                           | Description         
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                 |
 | ----------------------- | ------- | 
----------------------------------------- | ------------- | 
-------------------------------------- | 
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 |
-| count                   | integer | True                                     
 |               | > 0                              | The maximum number of 
requests allowed within a given time interval.                                  
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
               |
-| time_window             | integer | True                                     
 |               | > 0                        | The time interval corresponding 
to the rate limiting `count` in seconds.                                        
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
     |
+| count                   | integer | False                                    
 |               | > 0                              | The maximum number of 
requests allowed within a given time interval. Required if `rules` is not 
configured.                                                                     
                                                                                
                                                                                
                                                                                
                                                                                
                                                            |
+| time_window             | integer | False                                    
 |               | > 0                        | The time interval corresponding 
to the rate limiting `count` in seconds. Required if `rules` is not configured. 
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                            |
+| rules                   | array[object] | False                              
 |               |                            | A list of rate limiting rules. 
Each rule is an object containing `count`, `time_window`, and `key`.            
                                                                                
                                                                                
                                    |

Review Comment:
   Need to add rows for `rules.count`, `rules.time_winddow`, and `rules.key`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to