Copilot commented on code in PR #13023: URL: https://github.com/apache/apisix/pull/13023#discussion_r2835793850
########## docs/zh/latest/plugin-develop.md: ########## @@ -292,7 +292,7 @@ apisix: ## 检查外部依赖 -如果你的插件，涉及到一些外部的依赖和三方库，请首先检查一下依赖项的内容。如果插件需要用到共享内存，需要在 [自定义 Nginx 配置](./customize-nginx-configuration.md)，例如： +如果你的插件，涉及到一些外部的依赖和三方库，请首先检查一下依赖项的内容。如果插件需要用到共享内存，需要在 [自定义 Nginx 配置](./customize-nginx-configuration.md)声明，例如： Review Comment: This sentence reads a bit ungrammatical: “需要在 [自定义 Nginx 配置](./customize-nginx-configuration.md)声明…”. Consider adding “中” (or similar) after the link so it clearly means “declare it in the custom Nginx configuration” (e.g., “需要在 … 中声明”). ```suggestion 如果你的插件，涉及到一些外部的依赖和三方库，请首先检查一下依赖项的内容。如果插件需要用到共享内存，需要在 [自定义 Nginx 配置](./customize-nginx-configuration.md)中声明，例如： ``` ########## docs/en/latest/plugin-develop.md: ########## @@ -445,7 +445,7 @@ Note that the custom variables can't be used in features that depend on the Ngin For functions, write and improve the test cases of various dimensions, do a comprehensive test for your plugin! The test cases of plugins are all in the "__t/plugin__" directory. You can go ahead to find out. APISIX uses -[****test-nginx****](https://github.com/openresty/test-nginx) as the test framework. A test case (.t file) is usually +[**test-nginx**](https://github.com/openresty/test-nginx) as the test framework. A test case (.t file) is usually divided into prologue and data parts by \__data\__. Here we will briefly introduce the data part, that is, the part Review Comment: The test-nginx section says test cases are split by \__data\__. In test-nginx this marker is \__DATA\__ (uppercase), and the Chinese version here uses \__DATA\__. Please update the English docs to avoid misleading readers. ```suggestion divided into prologue and data parts by \__DATA\__. Here we will briefly introduce the data part, that is, the part ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
