Baoyuantop commented on code in PR #13014:
URL: https://github.com/apache/apisix/pull/13014#discussion_r2844030467
##########
t/node/upstream-mtls.t:
##########
@@ -783,3 +799,66 @@ passed
GET /hello
--- response_body
hello world
+
+
+
+=== TEST 23: get cert by tls.client_cert_id with secrets using env
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin")
+ local json = require("toolkit.json")
+
+ local data = {
+ type = "client",
Review Comment:
We also need to add test verification $secret://
##########
apisix/init.lua:
##########
@@ -554,7 +554,8 @@ function _M.handle_upstream(api_ctx, route,
enable_websocket)
core.log.info("matched ssl: ",
core.json.delay_encode(upstream_ssl, true))
- api_ctx.upstream_ssl = upstream_ssl
+
+ api_ctx.upstream_ssl = apisix_secret.fetch_secrets(upstream_ssl, true)
Review Comment:
need to add upstream_ssl fallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
