macdoor commented on code in PR #13040: URL: https://github.com/apache/apisix/pull/13040#discussion_r2866903464
########## t/plugin/kafka-logger.t: ########## @@ -98,6 +98,72 @@ done +=== TEST 3.1: api_version 2 for Kafka 4.x Review Comment: Thanks for the feedback. The current tests (TEST 3.1–3.3) only cover schema validation because: 1. CI uses bitnami/kafka:2.8.1, which supports api_version 0/1/2 2. Adding Kafka 4.x to CI would require upgrading ci/pod/docker-compose.plugin.yml and the Kafka image 3. api_version=2 is compatible with Kafka 2.x+ and has been supported by lua-resty-kafka I can either: - Add a follow-up issue to upgrade Kafka in CI and add integration tests, or - Add Kafka 4.x to CI in this PR if the maintainers prefer that approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
