Copilot commented on code in PR #3305: URL: https://github.com/apache/apisix-dashboard/pull/3305#discussion_r2893223739
########## e2e/server/apisix_conf.yml: ########## @@ -1,42 +1,22 @@ -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - apisix: - node_listen: 9080 # APISIX listening port + node_listen: 9080 enable_ipv6: false proxy_mode: http&stream stream_proxy: Review Comment: The Apache license header comment block was removed from this YAML file. If this repo requires ASF headers on source/config files (as seen in other e2e/server YAMLs), please restore the license header to keep licensing compliance consistent. ########## e2e/tests/services.stream_routes.list.spec.ts: ########## @@ -16,240 +16,231 @@ */ import { servicesPom } from '@e2e/pom/services'; import { randomId } from '@e2e/utils/common'; +import { env } from '@e2e/utils/env'; import { e2eReq } from '@e2e/utils/req'; import { test } from '@e2e/utils/test'; import { uiGoto } from '@e2e/utils/ui'; -import { expect } from '@playwright/test'; +import { expect, type Page } from '@playwright/test'; Review Comment: `env` is imported but never used in this spec file. This will fail lint/typecheck with unused-import rules; please remove the import (or use it if intended). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
