Copilot commented on code in PR #3291:
URL: https://github.com/apache/apisix-dashboard/pull/3291#discussion_r2895134166
##########
.github/workflows/lint.yml:
##########
@@ -0,0 +1,45 @@
+name: Lint
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - "**"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ lint:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v6
+
+ - uses: pnpm/action-setup@v4
+ name: Install pnpm
+
+ - name: Install Node.js
+ uses: actions/setup-node@v6
+ with:
+ node-version: 22
+ cache: 'pnpm'
+
+ - name: Install dependencies
+ run: pnpm install --frozen-lockfile
+
Review Comment:
`pnpm/action-setup@v4` is configured without `with: run_install: false`, but
a separate `pnpm install --frozen-lockfile` step follows. In this repo’s other
workflow (e2e.yml) `run_install: false` is set explicitly to avoid any implicit
install and keep behavior clear/consistent. Consider setting `run_install:
false` here as well (or remove the separate install step if you intend the
action to handle installs).
##########
.github/workflows/lint.yml:
##########
@@ -0,0 +1,45 @@
+name: Lint
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - "**"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ lint:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v6
+
+ - uses: pnpm/action-setup@v4
+ name: Install pnpm
+
+ - name: Install Node.js
+ uses: actions/setup-node@v6
+ with:
+ node-version: 22
Review Comment:
In other workflows (e.g. e2e.yml) `node-version` is quoted ("22"). Here it’s
an unquoted number, which YAML may treat as an integer; quoting keeps the value
type consistent and avoids any edge-case parsing issues in actions inputs.
```suggestion
node-version: "22"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
