Copilot commented on code in PR #953:
URL: https://github.com/apache/apisix-helm-chart/pull/953#discussion_r2980082485


##########
charts/apisix/templates/configmap.yaml:
##########
@@ -384,6 +384,7 @@ data:
       {{- end }}
         prefix: {{ .Values.etcd.prefix | quote }}    # configuration prefix in 
etcd
         timeout: {{ .Values.etcd.timeout }}    # 30 seconds
+        watch_timeout: {{ .Values.etcd.watch_timeout }} # 50 seconds, default 
value from apisix

Review Comment:
   Inline comment spacing is inconsistent with the surrounding 
`prefix`/`timeout` lines (those align comments with multiple spaces). Please 
adjust spacing so the rendered `config.yaml` stays consistently 
formatted/readable.
   ```suggestion
           watch_timeout: {{ .Values.etcd.watch_timeout }}    # 50 seconds, 
default value from apisix
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to