falvaradorodriguez commented on PR #12605: URL: https://github.com/apache/apisix/pull/12605#issuecomment-4161970467
> Hi @falvaradorodriguez, thank you for making the Redis limit-req path atomic via EVAL! > > Using a Lua script with EVAL to ensure atomicity of the rate limiting operation is the correct approach — the current non-atomic multi-command flow can have race conditions under high concurrency. With 12 reviews, this has been thoroughly discussed. > > **To confirm readiness**: > > 1. Are all 12 review comments addressed? Yes, they have all been checked and corrected where necessary. > 2. Has the EVAL script been tested under concurrent load to verify it resolves the race condition? Yes, in fact, in my case it has been validated in an environment with a high volume of requests > 3. The hash key with TTL approach — does it handle key expiration correctly for sliding windows? Yes, also validated. > This is an important correctness fix. Let's get it finalized! Thank you. Thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
