kayx23 commented on code in PR #13171: URL: https://github.com/apache/apisix/pull/13171#discussion_r3091118737
##########
docs/en/latest/plugins/limit-count.md:
##########
@@ -44,11 +47,11 @@ You may see the following rate limiting headers in the
response:
| Name | Type | Required
| Default | Valid values | Description
|
| ----------------------- | ------- |
----------------------------------------- | ------------- |
-------------------------------------- |
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
-| count | integer | False
| | > 0 | The maximum number of
requests allowed within a given time interval. Required if `rules` is not
configured.
|
-| time_window | integer | False
| | > 0 | The time interval corresponding
to the rate limiting `count` in seconds. Required if `rules` is not configured.
|
-| rules | array[object] | False
| | | A list of rate limiting rules.
Each rule is an object containing `count`, `time_window`, and `key`.
|
-| rules.count | integer | True
| | > 0 | The maximum number of requests
allowed within a given time interval.
|
-| rules.time_window | integer | True
| | > 0 | The time interval corresponding
to the rate limiting `count` in seconds.
|
+| count | integer or string | False
| | > 0 | The maximum
number of requests allowed within a given time interval. Required if `rules` is
not configured. Supports variable expressions from APISIX 3.16.0.
|
+| time_window | integer or string | False
| | > 0 | The time interval
corresponding to the rate limiting `count` in seconds. Required if `rules` is
not configured. Supports variable expressions from APISIX 3.16.0.
|
+| rules | array[object] | False
| | | A list of rate limiting rules.
Each rule is an object containing `count`, `time_window`, and `key`.
|
+| rules.count | integer or string | True
| | > 0 | The maximum number of
requests allowed within a given time interval. Supports variable expressions.
|
+| rules.time_window | integer or string | True
| | > 0 | The time interval
corresponding to the rate limiting `count` in seconds. Supports variable
expressions.
|
Review Comment:
Apache plugin docs use
> [lua-resty-expr](https://github.com/api7/lua-resty-expr)
Replace all in these docs please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
