nic-6443 commented on code in PR #13234: URL: https://github.com/apache/apisix/pull/13234#discussion_r3094280693
########## t/lib/fixture_loader.lua: ########## @@ -0,0 +1,142 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE file distributed with +-- this work for additional information regarding copyright ownership. +-- The ASF licenses this file to You under the Apache License, Version 2.0 +-- (the "License"); you may not use this file except in compliance with +-- the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, software +-- distributed under the License is distributed on an "AS IS" BASIS, +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +-- See the License for the specific language governing permissions and +-- limitations under the License. +-- + +--- Test fixture loader for AI proxy mock responses. +-- Loads fixture files from t/fixtures/ and serves them based on the +-- X-AI-Fixture request header. +-- +-- Supported headers: +-- X-AI-Fixture: <path> -- fixture file path relative to t/fixtures/ +-- X-AI-Fixture-Status: <code> -- optional HTTP status code (default 200) + +local _M = {} +local io = io +local ngx = ngx + +local fixture_base_dir + + +local function get_fixture_dir() + if fixture_base_dir then + return fixture_base_dir + end + + local constants = require("apisix.constants") + local lua_home = constants and constants.apisix_lua_home + if type(lua_home) ~= "string" or lua_home == "" then + return nil, "apisix_lua_home is not initialized" + end + fixture_base_dir = lua_home .. "/t/fixtures/" + return fixture_base_dir +end + + +function _M.load(name) + if type(name) ~= "string" or #name == 0 or #name > 256 then + return nil, "invalid fixture name" + end + if name:sub(1, 1) == "/" or name:find("..", 1, true) then + return nil, "invalid fixture name" + end + if not name:match("^[%w%._/-]+$") then + return nil, "invalid fixture name" + end + + local dir, dir_err = get_fixture_dir() + if not dir then + return nil, dir_err + end + local path = dir .. name + local f = io.open(path, "r") + if not f then + return nil, "fixture not found" + end + local content, read_err = f:read("*a") + local ok, close_err = f:close() + if not content then + return nil, "failed to read fixture: " .. (read_err or "unknown error") + end + if not ok then + return nil, "failed to close fixture: " .. (close_err or "unknown error") + end + return content +end + + +-- Replace {{model}} placeholder with the model from request body. +local function apply_template(content) + if not content:find("{{model}}", 1, true) then + return content + end + + ngx.req.read_body() + local body_data = ngx.req.get_body_data() + if not body_data then + return content:gsub("{{model}}", "unknown") + end + + local json = require("cjson.safe") + local body = json.decode(body_data) + if not body or not body.model then + return content:gsub("{{model}}", "unknown") + end + + return content:gsub("{{model}}", function() return body.model end) +end Review Comment: Already fixed in previous commit - using function replacement in gsub to avoid % interpretation. ########## t/plugin/ai-request-rewrite2.t: ########## @@ -112,7 +53,7 @@ __DATA__ }, "provider": "openai", "override": { - "endpoint": "http://localhost:6724/check_extra_options"; + "endpoint": "http://127.0.0.1:1980/check_extra_options"; }, Review Comment: Already added check_extra_options handler to t/lib/server.lua in previous commit. ########## t/plugin/ai-request-rewrite2.t: ########## @@ -200,7 +141,7 @@ override.endpoint is required for openai-compatible provider "model": "gpt-35-turbo-instruct" }, "override": { - "endpoint": "http://localhost:6724/test/params/in/overridden/endpoint?some_query=yes"; + "endpoint": "http://127.0.0.1:1980/test/params/in/overridden/endpoint?some_query=yes"; }, Review Comment: Already added test_params_in_overridden_endpoint handler to t/lib/server.lua in previous commit. ########## t/plugin/ai-request-rewrite.t: ########## @@ -604,7 +528,7 @@ passed }, "provider": "openai", "override": { - "endpoint": "http://localhost:6724/bad_request"; + "endpoint": "http://127.0.0.1:1980/bad_request"; }, "ssl_verify": false, Review Comment: Already added bad_request handler to t/lib/server.lua in previous commit. ########## t/plugin/ai-request-rewrite2.t: ########## @@ -244,7 +185,7 @@ passed }, "provider": "openai", "override": { - "endpoint": "http://localhost:6724/check_extra_options"; + "endpoint": "http://127.0.0.1:1980/check_extra_options"; }, "ssl_verify": false, Review Comment: Same as above - check_extra_options handler was already added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
