Baoyuantop commented on PR #13178:
URL: https://github.com/apache/apisix/pull/13178#issuecomment-4285711008
1. **Breaking change handling**: `session.cookie.lifetime` was removed
outright without a backward-compatible migration path. Please add an internal
mapping (e.g., map `cookie.lifetime` to `absolute_timeout`) or at least keep
the old field during a deprecation period.
2. **Schema design**: Rather than hardcoding all ~30 lua-resty-session 4.x
properties into the schema, consider explicitly defining only the essential
ones (e.g., `cookie_name`, `cookie_path`) and allowing the rest via
`additionalProperties`. Benefits:
- No APISIX schema changes needed when lua-resty-session adds new config
options
- Reduced maintenance burden
- Cleaner schema
Looking forward to the code update for further review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
