nic-6443 commented on code in PR #13249: URL: https://github.com/apache/apisix/pull/13249#discussion_r3114891024
########## apisix/plugins/ai-protocols/bedrock-converse.lua: ########## @@ -0,0 +1,283 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE file distributed with +-- this work for additional information regarding copyright ownership. +-- The ASF licenses this file to You under the Apache License, Version 2.0 +-- (the "License"); you may not use this file except in compliance with +-- the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, software +-- distributed under the License is distributed on an "AS IS" BASIS, +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +-- See the License for the specific language governing permissions and +-- limitations under the License. +-- + +--- Bedrock Converse protocol adapter (client-side). +-- Handles detection and response parsing for the Amazon Bedrock +-- Converse API format. Non-streaming only in this phase. + +local core = require("apisix.core") +local string_sub = string.sub +local type = type +local ipairs = ipairs +local table = table + +local _M = {} + + +--- Detect whether the request matches the Bedrock Converse API format. +-- Uses URI suffix (/converse) and body (valid JSON table with messages). +function _M.matches(body, ctx) + local uri = ctx.var and ctx.var.uri + return uri and string_sub(uri, -9) == "/converse" + and type(body) == "table" and type(body.messages) == "table" +end + + +--- Check whether the request is a streaming request. +-- Streaming is not supported in this phase. +function _M.is_streaming(body) + return false +end + + +--- Prepare the outgoing request body for the target provider. +-- Remove fields Bedrock doesn't accept. +function _M.prepare_outgoing_request(body) + body.stream = nil Review Comment: This should be a TODO item, not that Bedrock doesn't accept it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
