Yilialinn commented on code in PR #13275:
URL: https://github.com/apache/apisix/pull/13275#discussion_r3158243054
##########
docs/en/latest/plugins/prometheus.md:
##########
@@ -92,7 +92,7 @@ Reload APISIX for changes to take effect.
| Name | Type | Required | Default | Valid values | Description
|
| ------------- | ------- | -------- | ------- | ------------ |
------------------------------------------ |
-| prefer_name | boolean | | False | | If true, export
Route/Service name instead of their ID in Prometheus metrics. |
+| prefer_name | boolean | False | false | | If true, export
Route/Service name instead of their ID in Prometheus metrics. |
Review Comment:
The "Required" line is capitalized, using "True" or "False"
<img width="2375" height="897" alt="image"
src="https://github.com/user-attachments/assets/38d0d7ae-1132-4cac-b0e4-22a0d500afb1";
/>
The default line remains the same as
<img width="1367" height="500" alt="image"
src="https://github.com/user-attachments/assets/614411bc-2c55-46f5-8f03-daf3d267fcff";
/>
It's reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
