AlinsRan commented on code in PR #13344: URL: https://github.com/apache/apisix/pull/13344#discussion_r3215955799
########## apisix/plugins/oas-validator.lua: ########## @@ -0,0 +1,298 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE file distributed with +-- this work for additional information regarding copyright ownership. +-- The ASF licenses this file to You under the Apache License, Version 2.0 +-- (the "License"); you may not use this file except in compliance with +-- the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, software +-- distributed under the License is distributed on an "AS IS" BASIS, +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +-- See the License for the specific language governing permissions and +-- limitations under the License. +-- + +local core = require("apisix.core") +local secret = require("apisix.secret") +local plugin = require("apisix.plugin") +local ov = require("resty.openapi_validator") +local http = require("resty.http") +local ngx_req = ngx.req +local ngx_md5 = ngx.md5 +local pairs = pairs +local ipairs = ipairs +local tostring = tostring +local tab_sort = table.sort +local tab_concat = table.concat + +local plugin_name = "oas-validator" + +local DEFAULT_SPEC_URL_TTL = 3600 + +local schema = { + type = "object", + properties = { + spec = { + description = "schema against which the request/response will be validated", + type = "string", + minLength = 1 + }, + spec_url = { Review Comment: no, it support http `https?` match oneOf `http` of `https`. ref: https://github.com/apache/apisix/pull/13344/changes#diff-ad598e1c79a6882d92774e7d1ed2b8687a038e121a1246740a8cab4076712e52R480 ``` === TEST 19: create route with spec_url for TTL test --- config location /t { content_by_lua_block { local t = require("lib.test_admin") local code, body = t.test('/apisix/admin/routes/1', ngx.HTTP_PUT, [[{ "uri": "/*", "plugins": { "oas-validator": { "spec_url": "http://127.0.0.1:1979/spec.json"; } }, "upstream": { "type": "roundrobin", "nodes": { "127.0.0.1:1970": 1 } } }]] ) if code >= 300 then ngx.status = code end ngx.say(body) } } --- response_body passed ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
