AlinsRan commented on PR #13356: URL: https://github.com/apache/apisix/pull/13356#issuecomment-4427473004
The body rewrite cache invalidation approach (body version counter + `patch.lua` monkey-patching + `set_body_data` hook) has been reverted from this PR. The existing variable-level cache in `ctx.__index` has the same limitation — it does not invalidate on `set_body_data` either — so fixing it only for the body-level cache would be inconsistent and add complexity without addressing the general problem. That is a separate concern for a future PR. This PR now contains only the core optimization: `get_parsed_request_body` caches the parsed body table in `ctx` for the request lifetime, so `json.decode` is called at most once per request regardless of how many different `post_arg.*` keys are accessed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
