nic-6443 commented on code in PR #13386:
URL: https://github.com/apache/apisix/pull/13386#discussion_r3263549628
##########
apisix/cli/config.lua:
##########
@@ -29,6 +29,7 @@ local _M = {
enable_server_tokens = true,
extra_lua_path = "",
extra_lua_cpath = "",
+ request_body_json_lib = "qjson",
Review Comment:
The default was chosen for the large request-body path this change targets.
In the benchmark used for this PR, qjson was much faster than cjson on large
OpenAI chat completion payloads, and unlike simdjson it can also be used for
the AI upstream encode path.
That said, your concern about making a newer JSON library the default is
fair. The PR keeps cjson as an explicit option and falls back to cjson if qjson
cannot be loaded, but if maintainers prefer a conservative rollout I can change
the APISIX default back to cjson and leave qjson as opt-in first. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
