membphis commented on PR #13391: URL: https://github.com/apache/apisix/pull/13391#issuecomment-4505339274
@AlinsRan Changing the default to 10ms looks fine, but a few places still need to be updated so the behavior is documented consistently: The PR description still says 0 (default); it should say the default is 10ms, and 0 disables background interval flushing. The comment in base.lua still says == 0 (default), but the schema default is now 10. The configuration docs should explicitly state what 0 means: streaming_flush_interval_ms = 0 uses per-chunk synchronous flushing, i.e. ngx.flush(true); values > 0 use the background thread to flush periodically with ngx.flush(false). The tests currently cover explicit 0 and 50; it would be good to add one case where the field is omitted and the 10ms default is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
