nic-6443 commented on code in PR #13412: URL: https://github.com/apache/apisix/pull/13412#discussion_r3280308385
########## ci/linux-install-openresty.sh: ########## @@ -54,8 +54,9 @@ fi install_apisix_runtime if [ ! "$ENABLE_FIPS" == "true" ]; then -curl -o /usr/local/openresty/openssl3/ssl/openssl.cnf \ - https://raw.githubusercontent.com/api7/apisix-build-tools/apisix-runtime/${APISIX_RUNTIME}/conf/openssl3/openssl.cnf + APISIX_BUILD_TOOLS_REF="${APISIX_BUILD_TOOLS_REF:-apisix-runtime/${APISIX_RUNTIME}}" + curl -o /usr/local/openresty/openssl3/ssl/openssl.cnf \ Review Comment: Fixed in 31af10f9d. The download now uses `curl -fsSL` so a bad ref or missing file fails immediately. ########## ci/redhat-ci.sh: ########## @@ -39,8 +39,9 @@ install_dependencies() { yum install -y openresty-pcre-devel openresty-zlib-devel install_apisix_runtime + APISIX_BUILD_TOOLS_REF="${APISIX_BUILD_TOOLS_REF:-apisix-runtime/${APISIX_RUNTIME}}" curl -o /usr/local/openresty/openssl3/ssl/openssl.cnf \ Review Comment: Fixed in 31af10f9d. The RedHat path now uses `curl -fsSL` for the same fail-fast behavior. ########## ci/linux-install-openresty.sh: ########## @@ -54,8 +54,9 @@ fi install_apisix_runtime if [ ! "$ENABLE_FIPS" == "true" ]; then -curl -o /usr/local/openresty/openssl3/ssl/openssl.cnf \ - https://raw.githubusercontent.com/api7/apisix-build-tools/apisix-runtime/${APISIX_RUNTIME}/conf/openssl3/openssl.cnf + APISIX_BUILD_TOOLS_REF="${APISIX_BUILD_TOOLS_REF:-apisix-runtime/${APISIX_RUNTIME}}" + curl -o /usr/local/openresty/openssl3/ssl/openssl.cnf \ Review Comment: Fixed in 31af10f9d. The download now uses `curl -fsSL` so a bad ref or missing file fails immediately. ########## ci/redhat-ci.sh: ########## @@ -39,8 +39,9 @@ install_dependencies() { yum install -y openresty-pcre-devel openresty-zlib-devel install_apisix_runtime + APISIX_BUILD_TOOLS_REF="${APISIX_BUILD_TOOLS_REF:-apisix-runtime/${APISIX_RUNTIME}}" curl -o /usr/local/openresty/openssl3/ssl/openssl.cnf \ Review Comment: Fixed in 31af10f9d. The RedHat path now uses `curl -fsSL` for the same fail-fast behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
