AlinsRan opened a new pull request, #13627:
URL: https://github.com/apache/apisix/pull/13627

   ### Description
   
   Bumps `lua-resty-healthcheck-api7` from `3.2.1-0` to `3.2.2-0` and adds a 
regression test for the stale-target cleanup it fixes.
   
   The new library release carries api7/lua-resty-healthcheck#55. Before it, 
the health-check library advanced a **module-level** cleanup timestamp *inside* 
its per-checker loop, so only the **first** checker was purged each window. 
With multiple health-checked upstreams the rest kept their 
`delayed_clear()`-marked nodes forever — still returned by the control API 
(#13385) and still actively probed (#13141). The release also makes the 
periodic lock holder release the lock when it has no active checker left 
(#13235).
   
   This is reproducible only with **multiple** health-checked upstreams; a 
single-upstream setup always cleans (its sole checker is the "first" one), 
which is why earlier single-upstream repros failed.
   
   ### Tests
   
   `t/node/healthcheck-stale-cleanup.t`: two health-checked upstreams each drop 
a node, then the test asserts both removed nodes are gone from 
`/v1/healthcheck`.
   
   Verified locally against both library versions:
   
   | lua-resty-healthcheck-api7 | result |
   |---|---|
   | `3.2.1-0` (before) | **FAIL** — `stale: 1` (the second checker keeps its 
removed node) |
   | `3.2.2-0` (this PR) | **PASS** — `stale: 0` |
   
   ### Note on CI / merge order
   
   This PR depends on the `3.2.2-0` rock being available. Until 
api7/lua-resty-healthcheck#56 is merged, tagged `v3.2.2`, and published, `make 
deps` cannot resolve the dependency and CI will be red. Merge order: release 
the library first, then this PR.
   
   Relates to #13385, #13141, #13235.
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to