ecsimsw commented on PR #13607:
URL: https://github.com/apache/apisix/pull/13607#issuecomment-4885335854
@juzhiyuan
Hi, thank you for reviewing.
It's exciting to contribute to a project that I've been actively using at
work.
I've checked the CI failures.
The [plugin test
environment](https://github.com/apache/apisix/blob/master/ci/pod/kafka/kafka-server/env/common.env)
does not have a Kafka SSL listener, so the TLS integration tests could not
connect.
The schema validation tests pass fine.
The [last test
environment](https://github.com/apache/apisix/blob/master/ci/pod/kafka/kafka-server/env/last.env)
already has Kafka SSL configured.
I can add the SSL config following the last environment setup, but since
it's shared infrastructure, I'd like to get your input before making changes.
1. Add Kafka SSL to the plugin test environment, similar to the last
environment.
2. Keep only schema validation tests — consistent with how SASL tests are
structured.
Which approach would you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
