moonming commented on issue #3395:
URL:
https://github.com/apache/apisix-dashboard/issues/3395#issuecomment-4932691696
I re-verified this against current `master` (`9979b31`), and the client-side
blocker described here is **already gone**:
- Submitting the Add Route form with only `uri` filled sends the POST body
`{"uri":"/..."}` — no `upstream` object is injected, and the form does not
block submission on a missing upstream (captured the actual XHR body to
confirm).
- A route with only `uri` + the `public-api` plugin is accepted by the Admin
API (`201`) with that payload shape.
So on master you can bind `public-api` without filling in an upstream. The
behavior reported here matches the 3.16-era embedded dashboard build, which
predates the current form/producer pipeline.
Two follow-ups so this stays fixed:
1. There is currently **no e2e regression test** for the "plugins-only
route, no upstream" path (`grep -rn public-api e2e/` is empty) — I'll include
one in an upcoming PR.
2. Cosmetic residue: `FormItemNodes` still renders a `required` asterisk on
upstream nodes even in the route-form context where the whole upstream section
is optional — misleading, worth a small fix.
Suggest verifying on the next release build and closing this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
