moonming commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4932691935
This was fixed by #3391 (`c8d3466`) and I verified the coverage on current `master` (`9979b31`): The confirmation now lives in the single shared card component — `src/components/form-slice/FormItemPlugins/PluginCard.tsx` wraps the delete action in `modals.openConfirmModal(...)`. Since every surface renders plugin cards through `PluginCard` (via `PluginCardList`), the confirm dialog applies to all of them: - Routes / Services / Consumers / Credentials / Plugin Configs / Global Rules form sections - the Plugin Metadata page (where confirm precedes an immediate API `DELETE`) The regression suite added in #3391 pins both paths (`e2e/tests/regression/form.plugin-delete-confirmation.spec.ts`: dialog required, chip survives cancel, confirm removes). This can be closed. One small follow-up worth a separate cleanup: the plugin-card confirm modal's wording/styling differs slightly from `DeleteResourceBtn`'s (not centered, no bold target name) — unifying them into one shared delete-confirm helper would keep the UX consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
