moonming commented on PR #3419:
URL:
https://github.com/apache/apisix-dashboard/pull/3419#issuecomment-4932884218
Post-push audit findings addressed in ffb12f13:
- **H1 (failed plugin still offered via Select Plugins drawer)** — fixed:
the hook now exposes `failedPluginNames`; the drawer offering subtracts it, and
the `curPlugin` fallback only hands out an empty `{}` for plugins genuinely
offered as unconfigured. Pinned by a new fault-injection e2e (500 on one probe
→ toast appears, plugin absent from drawer).
- **M2 (no recovery for transient failures)** — real (non-404) failures now
retry up to 2 times; 404 probes never retry, so the probe volume for the normal
case is unchanged.
- **M3 (revert coverage)** — the new second test covers the exclusion hunk;
reverting either hunk now fails a spec.
- **M1 (network errors don't toast)** — pre-existing interceptor gap,
intentionally out of scope here; tracked in #3417 ("Network-level failure …
zero feedback") with a `MutationCache.onError`/interceptor follow-up.
- **L1 (toast-storm on per-plugin 500s)** — mitigated by the interceptor's
dedup-by-message (`notifications.show({ id: message })`) plus the Mantine
`limit={5}` cap; noted for the record.
- **L2 (settle-poll window)** — widened the quiet window to 1s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
