moonming commented on PR #3418: URL: https://github.com/apache/apisix-dashboard/pull/3418#issuecomment-4932924410
Post-push audit findings addressed in 61fa5b03: - **M1 (Retry no-op for suspense-thrown detail-page errors)** — fixed with the documented TanStack Router+Query pattern: `useQueryErrorResetBoundary().reset()` in the root error component before Retry re-runs the tree. - **M2 (no automated coverage of the Retry recovery flow)** — added a `fresh install recovery` e2e: empty storage state → error screen + settings modal → enter key → **Retry** → recovered routes list, with no `page.reload()`. - **M3 (blanket catch swallows non-axios bugs)** — the catch now rethrows anything that isn't an axios error, so failures thrown by `onSuccess`/`invalidateQueries` surface again. - **L1 (ordering window in the negative toast assertion)** — the spec now anchors on the interceptor's red `failed to check token` toast (emitted strictly before any success-chain toast in both worlds) before asserting zero success toasts. - **L2 (unhandled rejections from add/edit `mutateAsync`)** — pre-existing and out of scope; covered by the `MutationCache.onError` follow-up tracked in #3417. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
