moonming commented on PR #3420:
URL:
https://github.com/apache/apisix-dashboard/pull/3420#issuecomment-4933014806
Post-push audit findings addressed in 0635321f:
- **M1 (0/false semantics untested)** — added a test asserting `0` and
`false` count as filled; a truthiness-based re-implementation now fails the
suite.
- **L1 (object values always count as filled)** — documented at the
`isFilled` definition so a future object/string adopter isn't ambushed.
- **L2 (scoping only in the script argument)** — `test.include:
['src/**/*.test.{ts,tsx}']` added to `vite.config.ts`; a bare `vitest` no
longer collects the Playwright specs.
- **L3 (type-level narrowing imprecision)** — acknowledged as pre-existing
and left as-is per the audit's recommendation (zero call sites).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
