moonming commented on PR #3422:
URL:
https://github.com/apache/apisix-dashboard/pull/3422#issuecomment-4933121648
Post-push audit findings addressed in 947836a6:
- **HIGH (pending refresh cancelled on modal close)** — fixed with `{ delay:
500, flushOnUnmount: true }`; Mantine's numeric-arg form hard-sets
`flushOnUnmount: false` and cancels on unmount, so paste-then-close would have
left every query in its 401 error state.
- **MEDIUM (spec never verified the refresh fires)** — the spec now requires
a successful (`res.ok()`) Admin API response after typing completes; 401-retry
noise alone can no longer satisfy it.
- **MEDIUM (tight <8 bound)** — bound is now relative: `adminRequests <
adminKey.length` (old behavior ≥ one refetch per keystroke; fixed behavior ~a
handful), with real headroom against retry noise.
- **LOW (double-fetch)** — switched to `invalidateQueries({ refetchType:
'none' })` + a single `refetchQueries()`: one fetch per query, still covering
observer-less error-state queries that wrong-key recovery depends on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
