ecsimsw commented on code in PR #13607:
URL: https://github.com/apache/apisix/pull/13607#discussion_r3587063595
##########
apisix/plugins/error-log-logger.lua:
##########
@@ -185,6 +195,7 @@ local _M = {
function _M.check_schema(conf, schema_type)
if schema_type == core.schema.TYPE_METADATA then
+ core.utils.check_tls_bool({"kafka.tls.verify"}, conf, plugin_name)
Review Comment:
@AlinsRan
Thanks for catching.
I checked that with tls verify omitted, kafka.tls.verify is still nil at
that point, so the warning hook was skipped.
I've moved error-logger's call after the schema check, matching kafka-logger.
I also added a security-warning test for the `tls={}` case. It checks that
the warning is emitted when verify is omitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
