AlinsRan opened a new pull request, #13716:
URL: https://github.com/apache/apisix/pull/13716

   ### Description
   
   `t/plugin/lago.t` has been skipped as a whole file since #12903 
(`plan(skip_all)`), leaving the lago plugin with no test-nginx coverage at all.
   
   The file has two cases and only one of them can be flaky:
   
   - **TEST 1** — pure `check_schema` validation, plain Lua, no network, no 
docker. It was never the problem; it was just collateral damage of the 
file-level skip.
   - **TEST 2** — runs `pnpm test plugin/lago.spec.mts`, which clones 
`getlago/lago` over the network and brings up its docker compose stack. This is 
the flaky one.
   
   So this PR replaces the file-level `plan(skip_all)` with a per-block `--- 
SKIP` on TEST 2 and restores `use t::APISIX 'no_plan';`. TEST 1 runs again; 
TEST 2 stays skipped.
   
   I chose `--- SKIP` over splitting TEST 1 into a separate `.t` file because 
it keeps the diff to three lines, leaves TEST 2 in place for whoever fixes the 
flake, and does not add a new file that CI has to pick up. The comment at the 
top of the file points back at #12904 so the skip does not become invisible 
again.
   
   This does not fix the underlying flake and does not touch 
`apisix/plugins/lago.lua`, so it only partially addresses the issue.
   
   #### Which issue(s) this PR fixes:
   
   Relates to #12904
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to