nic-6443 commented on code in PR #13616:
URL: https://github.com/apache/apisix/pull/13616#discussion_r3619804612
##########
apisix/plugins/openid-connect.lua:
##########
@@ -910,6 +926,12 @@ function _M.rewrite(plugin_conf, ctx)
if refresh_token and conf.set_refresh_token_header then
core.request.set_header(ctx, "X-Refresh-Token", refresh_token)
end
+
+ -- Add X-Enc-ID-Token header, maybe.
+ local enc_id_token = session:get("enc_id_token")
+ if enc_id_token and conf.set_enc_id_token_header then
+ core.request.set_header(ctx, "X-Enc-ID-Token", enc_id_token)
Review Comment:
`enc_id_token` is an internal naming within the lua-resty-openidc library,
which is unintelligible to gateway users. I suggest naming it `X-Raw-ID-Token`,
as it aligns with the description of this field in the schema. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
