Copilot commented on code in PR #2808:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2808#discussion_r3627920556
##########
internal/adc/client/client.go:
##########
@@ -81,6 +81,24 @@ type Task struct {
Resources *adctypes.Resources
}
+// MarshalLog implements logr.Marshaler so logging a Task never dumps the
+// secret-bearing Resources bodies (SSL private keys, consumer credentials).
+// Configs redact their own Token via Config.MarshalJSON.
Review Comment:
The MarshalLog comment mentions Config.MarshalJSON redacting the Token, but
this MarshalLog implementation no longer logs the Config objects at all (it
logs only config names). This is misleading for readers trying to understand
what is (and isn’t) emitted in Task logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
