LiteSun commented on code in PR #3438:
URL: https://github.com/apache/apisix-dashboard/pull/3438#discussion_r3628772503
##########
src/utils/producer.ts:
##########
@@ -102,8 +117,7 @@ export const pipeProduce = (...funcs: ((a: any) =>
unknown)[]) => {
...fs,
produceRmDoubleUnderscoreKeys,
Review Comment:
`plugins` is snapshotted only after `produceRmDoubleUnderscoreKeys` has
recursively traversed it, so plugin configuration fields beginning with `__`
have already been deleted. For example, `{ "my-plugin": { "__mode": "strict" }
}` is not passed through verbatim. Since the stated contract is that plugin
JSON is owned by the gateway, please skip the `plugins` subtree during UI-key
cleanup or detach it before all generic cleaning, and add a regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
