lxbme opened a new pull request, #3444: URL: https://github.com/apache/apisix-dashboard/pull/3444
Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix **What changes will this PR take into?** This addresses the "the repo's only unit test never runs in CI" item of the frontend review in #3417. A `test` script (`vitest run src`) already exists in `package.json`, and the suite has grown from the single `upstreams.test.ts` the review noted to several files (`producer`, `zod`, `upstreams`, `labels-conversion`, `nodes-conversion`) guarding real fixes. But no workflow ever invoked it, so all of that coverage was unenforced — a change could break a unit test and still merge green. This adds one step to the existing `lint` workflow (which already sets up pnpm/Node and installs dependencies) to run `pnpm test` after the type check. Placing it in the existing job reuses the setup rather than duplicating it in a new workflow. **Related issues** Part of #3417 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first This is a CI-configuration change only; no application code is touched, so there is nothing for the e2e suite to exercise. Verified locally that `pnpm test` passes (`vitest run src` — 5 files, 38 tests) and that the modified `lint.yml` is valid YAML. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
