nic-6443 commented on code in PR #2811:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2811#discussion_r3654148566
##########
api/v1alpha1/gatewayproxy_types.go:
##########
@@ -133,7 +133,10 @@ type ControlPlaneProvider struct {
Service *ProviderService `json:"service,omitempty"`
// TlsVerify specifies whether to verify the TLS certificate of the
control plane.
+ // Defaults to true. Setting it to false disables certificate
verification and
+ // exposes the AdminKey to man-in-the-middle attacks over https
endpoints.
// +optional
+ // +kubebuilder:default=true
Review Comment:
Agreed; this is already a concrete regression in the shipped manifests.
`examples/httpbin/{quickstart,httproute,ingress,tcproute}.yaml` use the
documented `https://127.0.0.1:7443` endpoint without `tlsVerify`, so they stop
syncing after this default changes. Since no CA material can be passed to ADC,
a private or self-signed CA has no secure migration path. Please add CA support
plus an upgrade path and update those examples before flipping the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
