moonming commented on PR #2078:
URL: https://github.com/apache/apisix-website/pull/2078#issuecomment-5087586615
Thanks — all six points were real, and the first one showed my fix was based
on a wrong assumption. Addressed in 442343c71.
**Client-side routing.** You're right that `target="_self"` does nothing
here: React Router intercepts the click after hydration regardless of target,
and patching the serialized HTML never reaches the props React hydrates with.
I've dropped that approach. Docusaurus now stops building the newest version
(`onlyIncludeVersions` in `doc/docusaurus.config.js`), so the version-less URLs
leave its route manifest entirely and a click from an archive page is a real
navigation. The deploy asserts that against the built `main.*.js` bundle
instead of against markup.
That change had a consequence worth flagging: with Docusaurus no longer
emitting those pages, the docs parity gate had nothing left to compare and
would have passed vacuously. It now checks the Astro build against the URLs
currently published on `asf-site`, so a page that works today cannot 404 after
a deploy.
**Sidebar depth.** Confirmed and fixed — 25 links under `Plugins >
Observability > {Tracers,Metrics,Loggers}` were being dropped. Replaced the
fixed-depth markup with a recursive component; `zipkin` and the other 24 are
back.
**Edit links.** Fixed. `sync-content.mjs` now records the ref each project
was cloned from (`release/3.17`, `v2.1.0`, `release/0.6.0`, …) and the pages
build the link from that ref plus `pathId` — the source-relative path — so a
frontmatter slug no longer points at a file that doesn't exist. Your
ingress-controller example now resolves to a real source file.
**Markdown twins — zh fallback.** Fixed: the English APISIX collection is
now also offered the `/zh/` prefix, covering the 192 zh pages that fall back to
English. Rather than rely on that mapping staying correct, I added a parity
check that fails the build if any content page lacks a twin.
**Markdown twins — zh articles in the index.** Fixed; the section is there
and the 13 pages are indexed.
**Version picker.** Not deferred — added. The migrated pages now carry a
`details/summary` picker listing the seven archived versions plus `next`, in
both locales, with no JavaScript.
On separability: happy to split the Markdown-twin commit into its own PR if
you'd prefer to review the Wave 3 switch on its own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
