xiaocanglan1 opened a new pull request, #2828: URL: https://github.com/apache/apisix-ingress-controller/pull/2828
### Type of change: - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - [ ] Documentation - [ ] Refactor - [ ] Chore - [ ] CI/CD or Tests ### What this PR does / why we need it: `ApisixUpstream` health check translation defaulted the active and passive health check types but never copied those values into the ADC upstream model. As a result, explicit `https` and `tcp` health check types were silently omitted from the APISIX upstream configuration. APISIX then defaulted active checks to HTTP, which can send plain HTTP probes to HTTPS upstream ports. This change preserves both active and passive health check types during translation. It adds unit coverage for default, HTTP, HTTPS, and TCP values, and extends the `ApisixUpstream` e2e contract to verify non-default types in the generated upstream configuration. ### Pre-submission checklist: - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? Not required; this restores documented behavior. - [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first** ### Verification ```shell go test ./internal/adc/translator go test ./test/e2e/crds/v2 -run '^$' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
