AlinsRan commented on PR #2798: URL: https://github.com/apache/apisix-ingress-controller/pull/2798#issuecomment-5114831175
Merged latest master into this branch and pushed a follow-up test commit. The fix itself is correct — `translateBackendRef` is the shared helper behind HTTPRoute/GRPCRoute/TLSRoute/ApisixRoute, so reading `appProtocol` there covers all of them. The Ingress path already handled ExternalName correctly, no change needed. The added test was failing CI though: the `without appProtocol` case expected `http`, but an unset appProtocol leaves `Upstream.Scheme` empty and lets the data plane default it — same as for cluster-IP services. Corrected that, and also added an assertion on `EnableWebsocket` plus a `kubernetes.io/ws` case, since the dropped `connection: upgrade` header is the actual symptom reported in #2793 and the original test only covered the scheme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
