AlinsRan commented on PR #2801: URL: https://github.com/apache/apisix-ingress-controller/pull/2801#issuecomment-5114828785
Thanks for the analysis — it's accurate: `translateSecret()` did reject Passthrough listeners before reaching the `TLSModePassthrough` case, and since `TranslateGateway` returns early on that error, the GatewayProxy global-rules/plugin-metadata aggregation was skipped as well. This has since been fixed on master by #2804 (commit `2a8d507e`), which returns early for Passthrough before the `certificateRefs` nil check and additionally defaults a nil `listener.TLS.Mode` to Terminate. Master also already carries an equivalent `TestTranslateSecret_Passthrough`. Rebasing this PR onto master would leave an empty diff, so I'm closing it — sorry the timing worked out that way, and thanks for the report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
