AlinsRan opened a new pull request, #13761:
URL: https://github.com/apache/apisix/pull/13761

   ### Description
   
   Follow-up to 
https://github.com/apache/apisix/pull/13717#discussion_r3662535767.
   
   After #12426 moved health checks to `healthcheck_manager`, nothing registers 
a clean handler any more: `config_util.add_clean_handler()` has no caller 
outside its own unit test. That makes every `fire_all_clean_handlers()` call a 
no-op and every `item.clean_handlers = {}` initialization dead weight on each 
config item.
   
   This removes the mechanism uniformly instead of dropping it from one config 
backend only:
   
   - `core.config_util`: drop `add_clean_handler`, `cancel_clean_handler`, 
`fire_all_clean_handlers`
   - `config_etcd` / `config_yaml` / `config_xds`: drop the fire sites and the 
`clean_handlers` initialization
   - `plugin.lua`: drop the field from the dummy global rule
   - `control/v1.lua`: drop the field from the routes/services dump
   - docs: drop the stale `clean_handlers` entries from the control API 
response samples
   - `t/core/config_util.t`: drop the test that only covered the removed API
   
   No behavior change — the removed code paths were unreachable.
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (if not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to