AlinsRan opened a new pull request, #2836:
URL: https://github.com/apache/apisix-ingress-controller/pull/2836

   ### Description
   
   Fixes the `APISIX E2E Test` failure on master (`TCPRoute With 
BackendTrafficPolicy` / `BackendTrafficPolicy scheme tls connects to the 
upstream over TLS`, `tcproute.go:190`, timing out with `Get 
"http://127.0.0.1:<port>/": EOF`).
   
   Two PRs landed on the same day and merged cleanly as text but not 
semantically:
   
   - #2830 added the `TCPRoute With BackendTrafficPolicy` context, whose 
Gateway listener uses `port: 80`.
   - #2818 moved the TCPRoute e2e Gateway listeners to `9100` — APISIX's 
physical `stream_proxy` TCP port — because the e2e controller runs with 
`listener_port_match_mode=auto`, where `sectionName` targeting injects 
`server_port` from the matched listener. It was written before #2830 existed, 
so it only updated the two contexts present at the time.
   
   As a result the BackendTrafficPolicy context produced a StreamRoute matching 
`server_port: 80` while connections actually arrive on `9100`, so the route 
never matched and the connection was reset. The two sibling contexts in the 
same file (`TCPRoute Base`, `TCPRoute With L4RoutePolicy`) already use `9100` 
and pass.
   
   The manifest was byte-identical in all three contexts, so instead of 
patching the port in place this hoists it to a single definition shared by the 
whole `Describe`, which removes the drift entirely.
   
   ### Which issue(s) this PR fixes
   
   Fixes the e2e failure introduced by the #2818 / #2830 merge order.
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to