Copilot commented on code in PR #13832:
URL: https://github.com/apache/apisix/pull/13832#discussion_r3792028125
##########
apisix/plugins/ldap-auth.lua:
##########
@@ -162,6 +163,12 @@ function _M.rewrite(conf, ctx)
end
consumer_mod.attach_consumer(ctx, consumer, consumer_conf)
+ -- the header carries the directory password, which is usually reusable
+ -- beyond this API, so it should not reach the upstream unless asked for
+ if conf.hide_credentials then
+ core.request.set_header(ctx, "Authorization", nil)
+ end
+
core.log.info("hit basic-auth access")
Review Comment:
Log message references "basic-auth" even though this is the ldap-auth
plugin; this makes log-based debugging and observability misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
