AlinsRan commented on code in PR #2826:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2826#discussion_r3860054482
##########
api/v1alpha1/gatewayproxy_types.go:
##########
@@ -136,6 +137,13 @@ type ControlPlaneProvider struct {
// +optional
TlsVerify *bool `json:"tlsVerify,omitempty"`
+ // CaBundle is a PEM-encoded CA certificate (or bundle) used to verify
the
+ // control plane's TLS certificate, in place of the system trust store.
+ // Set it when the control plane uses a self-signed or private CA
certificate.
+ // It has no effect when tlsVerify is false.
+ // +optional
+ CaBundle string `json:"caBundle,omitempty"`
Review Comment:
```yaml
caCert:
value: |
-----BEGIN CERTIFICATE-----
valueFrom:
secretKeyRef: {name: cp-ca, key: ca.crt}
```
I think this would be better, don't you think?
Secret can be left unimplemented for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
