Hockenba commented on PR #13651:
URL: https://github.com/apache/apisix/pull/13651#issuecomment-5449958479
> Thanks, 1-4 look good and `openid-connect-revocation.t` passes locally.
One issue with the new default = "open" on `revocation_fail_mode` is that it is
applied unconditionally, so every openid-connect route now carries
`"session":{"revocation_fail_mode":"open"}` even with revocation disabled (this
breaks `t/plugin/openid-connect.t` TEST 25 "Check defaults"). The intent is
"open only when revocation is redis", and lua-resty-session already does that
internally (defaults to open, only consulted on the revocation path). Please
drop the schema default, document it as the default in the table, and adjust
the TEST 2 assertions to expect nil. Also run the full
`t/plugin/openid-connect*.t` set before pushing.
Should be all addressed now. I ran all the openid-connect tests, and they
all passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
