AlinsRan commented on PR #2794: URL: https://github.com/apache/apisix-ingress-controller/pull/2794#issuecomment-5502298907
I've left a design review on the issue this implements: https://github.com/apache/apisix-ingress-controller/issues/2795#issuecomment-5502297588 Short version: `Client.Sync()` is the only push path, so excluding a type there stops that type from syncing at all rather than just skipping GC. The proposed alternative is to scope the sweep with the `manager-by` label instead, which needs no new configuration. Worth settling the direction on the issue before iterating on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
