johannes-engler-mw opened a new pull request, #2854: URL: https://github.com/apache/apisix-ingress-controller/pull/2854
<!-- Please answer these questions before submitting a pull request --> ### Type of change: - [x] CI/CD or Tests ### What this PR does / why we need it: `internal/controller` does not build on master. #2846 and #2850 each added a provider stub named `recordingProvider` to the package, and they landed independently: - `internal/controller/apisixconsumer_controller_test.go:45` - `internal/controller/gateway_controller_publishservice_test.go:49` ```console $ go vet ./internal/controller/ vet: internal/controller/gateway_controller_publishservice_test.go:49:6: recordingProvider redeclared in this block ``` `go vet` runs in the unit test job, in `make lint`, and in the e2e jobs' image build, so this turns every open pull request red — the e2e jobs never reach the test suite at all. This keeps the ApisixConsumer stub, which records the objects passed to `Delete` and can be told to fail, and gives it the `Update` counter the Gateway publishService tests use. No test assertions change. ```console $ go vet ./internal/controller/ && go test ./internal/controller/ ok github.com/apache/apisix-ingress-controller/internal/controller 0.649s ``` ### Pre-submission checklist: - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? — n/a, this only removes a duplicate test helper - [ ] Have you modified the corresponding document? — n/a - [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first** https://claude.ai/code/session_018uKEPFSzVot9nveU442tD8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
